[Openmp-commits] [PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:159
       omptarget_nvptx_threadPrivateContext->Level1TaskDescr(threadId);
-  ASSERT0(LT_FUSSY, newTaskDescr, "expected a task descr");
   newTaskDescr->InitLevelOneTaskDescr(ThreadLimit,
----------------
Do you really need to remove this?


================
Comment at: libomptarget/deviceRTLs/nvptx/src/supporti.h:191
   PRINT(LD_MEM, "malloc data of size %zu for %s: 0x%llx\n", size, msg, P64(ptr));
-  ASSERT(LT_SAFETY, ptr, "failed to allocate %zu bytes for %s\n", size, msg);
   return ptr;
----------------
Same, do you really need to remove this?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D53141