[Openmp-commits] [PATCH] D53141: [OpenMP][libomptarget] Add runtime function for pushing coalesced global records

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In https://reviews.llvm.org/D53141#1261996, @Hahnfeld wrote:

> I guess this will break the case when the `DataSize` passed to `__kmpc_data_sharing_push_stack()` needs additional alignment: With this change it is handled in `data_sharing_push_stack_common()` but `__kmpc_data_sharing_push_stack()` will determine `PushSize` without the adjustment and do the final pointer arithmetic.


Why `DataSize` might require an additional alignment? The `DataSize` must be already aligned.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D53141