[Openmp-commits] [PATCH] D52725: [libomptarget-nvptx] reduction: Determine if runtime uninitialized

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld created this revision.
Hahnfeld added reviewers: grokos, ABataev.
Herald added a subscriber: openmp-commits.

Pass in the correct value of isRuntimeUninitialized() which solves
parallel reductions as reported on the mailing list.
For reference: r333285 did the same for loop scheduling.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D52725

Files:
  libomptarget/deviceRTLs/nvptx/src/reduction.cu


Index: libomptarget/deviceRTLs/nvptx/src/reduction.cu
===================================================================
--- libomptarget/deviceRTLs/nvptx/src/reduction.cu
+++ libomptarget/deviceRTLs/nvptx/src/reduction.cu
@@ -148,7 +148,7 @@
                                      kmp_ShuffleReductFctPtr shflFct,
                                      kmp_InterWarpCopyFctPtr cpyFct,
                                      bool isSPMDExecutionMode,
-                                     bool isRuntimeUninitialized = false) {
+                                     bool isRuntimeUninitialized) {
   uint32_t BlockThreadId = GetLogicalThreadIdInBlock();
   uint32_t NumThreads = GetNumberOfOmpThreads(
       BlockThreadId, isSPMDExecutionMode, isRuntimeUninitialized);
@@ -242,7 +242,8 @@
     kmp_ShuffleReductFctPtr shflFct, kmp_InterWarpCopyFctPtr cpyFct) {
   return nvptx_parallel_reduce_nowait(global_tid, num_vars, reduce_size,
                                       reduce_data, shflFct, cpyFct,
-                                      /*isSPMDExecutionMode=*/isSPMDMode());
+                                      /*isSPMDExecutionMode=*/isSPMDMode(),
+                                      /*isRuntimeUninitialized=*/isRuntimeUninitialized());
 }
 
 EXTERN
@@ -270,7 +271,7 @@
     int32_t global_tid, int32_t num_vars, size_t reduce_size, void *reduce_data,
     kmp_ShuffleReductFctPtr shflFct, kmp_InterWarpCopyFctPtr cpyFct,
     kmp_CopyToScratchpadFctPtr scratchFct, kmp_LoadReduceFctPtr ldFct,
-    bool isSPMDExecutionMode, bool isRuntimeUninitialized = false) {
+    bool isSPMDExecutionMode, bool isRuntimeUninitialized) {
   uint32_t ThreadId = GetLogicalThreadIdInBlock();
   // In non-generic mode all workers participate in the teams reduction.
   // In generic mode only the team master participates in the teams
@@ -401,7 +402,8 @@
                                          kmp_LoadReduceFctPtr ldFct) {
   return nvptx_teams_reduce_nowait(global_tid, num_vars, reduce_size,
                                    reduce_data, shflFct, cpyFct, scratchFct,
-                                   ldFct, /*isSPMDExecutionMode=*/isSPMDMode());
+                                   ldFct, /*isSPMDExecutionMode=*/isSPMDMode(),
+                                   /*isRuntimeUninitialized=*/isRuntimeUninitialized());
 }
 
 EXTERN


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52725.167734.patch
Type: text/x-patch
Size: 2342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20181001/6f73d6ce/attachment-0001.bin>