[Openmp-commits] [PATCH] D47221: [cmake] Fix libomptarget/test/CMakeLists.txt

[Azharuddin Mohammed via Phabricator via Openmp-commits]

azharudd created this revision.
azharudd added reviewers: jlpeyton, AndreyChurbanov, Hahnfeld.
Herald added subscribers: llvm-commits, mgorny.

Should be variable name instead of variable reference. If the variable is
somehow unset, it messes up the if condition expression and causes a CMake
error.


Repository:
  rL LLVM

https://reviews.llvm.org/D47221

Files:
  libomptarget/test/CMakeLists.txt


Index: libomptarget/test/CMakeLists.txt
===================================================================
--- libomptarget/test/CMakeLists.txt
+++ libomptarget/test/CMakeLists.txt
@@ -1,6 +1,6 @@
 # CMakeLists.txt file for unit testing OpenMP offloading runtime library.
-if(NOT "${OPENMP_TEST_COMPILER_ID}" STREQUAL "Clang" OR
-   ${OPENMP_TEST_COMPILER_VERSION} VERSION_LESS 6.0.0)
+if(NOT OPENMP_TEST_COMPILER_ID STREQUAL "Clang" OR
+   OPENMP_TEST_COMPILER_VERSION VERSION_LESS 6.0.0)
   libomptarget_say("Can only test with Clang compiler in version 6.0.0 or later.")
   libomptarget_warning_say("The check-libomptarget target will not be available!")
   return()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47221.148083.patch
Type: text/x-patch
Size: 671 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180522/259e79a9/attachment.bin>