[Openmp-commits] [PATCH] D46901: [libomptarget-nvptx] Test bitcode compiler flags and enable by default

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea added inline comments.


================
Comment at: README.rst:264
+  by default if the build system determines that `CMAKE_C_COMPILER` is able to
+  compile and link the library.
 
----------------
When I use the latest Clang/LLVM to build an older version of the compiler the CMAKE_C_COMPILER  compiler would be used to compile the BCLIB. I've seen that I cannot successfully inline a bclib built with a newer version of LLVM. In the past (i.e. a few months ago) I got an error complaining about the LLVM version. 


================
Comment at: libomptarget/deviceRTLs/nvptx/CMakeLists.txt:148
+            -c ${infile} -o ${outfile}-sm_${sm}.bc
+          DEPENDS ${infile}
+          IMPLICIT_DEPENDS CXX ${infile}
----------------
Can we make the just-built compiler the default compiler if no other compiler has been provided by the user? This is always the compiler I want to use for the BCLIB compilation.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D46901