[Openmp-commits] [PATCH] D46533: [OMPT] Provide the right thread_num for ancestor levels

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue May 8 00:22:38 PDT 2018

Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

LGTM with some minor comments.

Comment at: runtime/src/ompt-specific.cpp:411
+        *thread_num = prev_team->t.t_master_tid;
+      //        *thread_num = team->t.t_master_tid;
Please remove.

Comment at: runtime/test/ompt/parallel/nested_thread_num.c:1
+// RUN: %libomp-compile-and-run | FileCheck %s
+// RUN: %libomp-compile-and-run | %sort-threads | FileCheck --check-prefix=THREADS %s
I think the `CHECK` prefix doesn't add additional coverage, can we remove this run?


More information about the Openmp-commits mailing list