[Openmp-commits] [PATCH] D44487: [OpenMP][libomptarget] Enable globalization for workers

[George Rokos via Phabricator via Openmp-commits]

grokos added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/data_sharing.cu:42-45
+  // Count the set bits in the 32 bit int version of Sh. If no bits
+  // are set then the thread calling this function is the active warp
+  // master thread.
+  return __popc(Sh) == 0;
----------------
gtbercea wrote:
> grokos wrote:
> > Remove this change, that was a bug which has been fixed already. I have pushed it upstream.
> Was there a bug fix for this published on fabricator prior to me posting it in this patch?
There was no revision on the Phabricator for this bug. I had the fix ready from clang-ykt but I hadn't pushed it onto the trunk. We don't need to call `__popc()`, just compare against 0.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D44487