[Openmp-commits] [PATCH] D48480: [OPENMP, NVPTX] Fixes for NVPTX RTL

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/sync.cu:36-38
 // Emit a simple barrier call in SPMD mode.  Assumes the caller is in an L0
 // parallel region and that all worker threads participate.
 EXTERN void __kmpc_barrier_simple_spmd(kmp_Indent *loc_ref, int32_t tid) {
----------------
Hahnfeld wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > Are you moving these functions for a reason? I think they are defined as extern, so there's no need to have them before calling them.
> > > 
> > > (Moving code makes reading patches very difficult, I think the only change in this file is in `__kmpc_barrier`, right?)
> > Right, only `__kmpc_[cancel_]barrier` has changed. But it uses these `generic|spmd` versions and the compiler cannot see them because they are defined/declared later. 
> They are declared in `interface.h` which should be included from `omptarget-nvptx.h`, no?
Ah, yes. Ok, I'll restore the original order.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D48480