[Openmp-commits] [PATCH] D49857: [OpenMP] Implement GOMP doacross compatibility

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: runtime/src/kmp_gsupport.cpp:615
     }                                                                          \
+    KMP_DOACROSS_FINI(status, gtid)                                            \
                                                                                \
----------------
This statement seems to cause the harm. I think this makes all threads free their doacross buffer after processing their last iteration, right?

That's breaking `runtime/test/worksharing/for/kmp_doacross_check.c` which has its own call to `__kmpc_doacross_fini` at line 46 :-(


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D49857