[Openmp-commits] [PATCH] D50001: [OpenMP] Fix new task creation

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, sconvent, caomhin.
Herald added subscribers: openmp-commits, guansong.

When OMPT is not supported this call generated an error:

  openmp/runtime/src/kmp_tasking.cpp:4018:3: error: no matching function for call to '__kmp_omp_task'
    __kmp_omp_task(NULL, gtid, new_task); // schedule new task
    ^~~~~~~~~~~~~~
  /localhd/gbercea/patch-compiler/src/projects/openmp/runtime/src/kmp_tasking.cpp:1511:11: note: candidate function not viable: no known conversion from 'int' to 'kmp_task_t *' (aka 'kmp_task *') for 2nd argument
  kmp_int32 __kmp_omp_task(kmp_int32 gtid, kmp_task_t *new_task,
            ^
  1 error generated.

This seems to fix it.

This was introduced in this patch: https://reviews.llvm.org/D49105


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D50001

Files:
  runtime/src/kmp_tasking.cpp


Index: runtime/src/kmp_tasking.cpp
===================================================================
--- runtime/src/kmp_tasking.cpp
+++ runtime/src/kmp_tasking.cpp
@@ -4015,7 +4015,7 @@
   // schedule new task with correct return address for OMPT events
   __kmp_omp_taskloop_task(NULL, gtid, new_task, codeptr_ra);
 #else
-  __kmp_omp_task(NULL, gtid, new_task); // schedule new task
+  __kmp_omp_task(gtid, new_task, true); // schedule new task
 #endif
 
   // execute the 1st half of current subrange


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50001.158042.patch
Type: text/x-patch
Size: 507 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180730/5dac3aac/attachment.bin>