[Openmp-commits] [PATCH] D44186: [OpenMP] New clang/libomptarget map interface: remove translation code

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jul 18 23:34:25 PDT 2018

Hahnfeld accepted this revision.
Hahnfeld added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D44186#1166793, @grokos wrote:

> Let's coordinate in order to commit both patches at the same time. The patch is currently blocked by Jonas.
> @Hahnfeld: Is there any other issue that needs to be addressed? If not, is this good to go?

I think we were mainly waiting for the Clang patch, removing the translation code itself is highly desirable (and is blocking some outstanding fixes).

A second point was the alignment problem which I think I now understood. Please update the patch description accordingly so that others can get the rationale from looking at the commit log.
If the code you posted inline triggers the problem (if not, I'd need a minimal example that would break), I'm happy for now and will test after the changes have landed.

One minor question inline, but I think we can proceed for now as long as we don't regress.

Comment at: libomptarget/src/omptarget.cpp:202-204
+    if (member_of(arg_types[i]) < 0 && next_i < arg_num &&
+        member_of(arg_types[next_i]) == i) {
+      padding = (int64_t)HstPtrBegin % alignment;
Again looking at this code, what if the `member_of` comes later and is not directly adjacent?

  rOMP OpenMP


More information about the Openmp-commits mailing list