[Openmp-commits] [PATCH] D49386: Make tests unsupported if libatomic cannot be found.

Taewook Oh via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Mon Jul 16 11:12:11 PDT 2018


twoh added inline comments.


================
Comment at: runtime/test/lit.cfg:56-57
     libs += " -latomic"
+elif '-fopenmp' in config.test_openmp_flags:
+    config.unsupported = True
 
----------------
Hahnfeld wrote:
> I think what you want to test here is whether you are compiling with Clang? If so, please use `config.test_c_compiler` or `config.test_compiler_features`.
Thanks for the comment! I couldn't quite get it why are you thinking that I want to check if the compiler is clang. Following https://reviews.llvm.org/rL336467, `-latomic` is added if `-fopenmp` is given, so that's what I'm checking here. Don't all test cases here assume that they are compiling with clang?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D49386





More information about the Openmp-commits mailing list