[Openmp-commits] [PATCH] D49204: [OpenMP][libomptarget] Fix data sharing and globalization infrastructure to work in SPMD mode

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea marked an inline comment as done.
gtbercea added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:316
+      __kmpc_data_sharing_worker_slot_static worker_rootS[WARPSIZE];
   __align__(16) __kmpc_data_sharing_master_slot_static master_rootS[1];
 };
----------------
grokos wrote:
> Is `master_rootS` still needed? From what I understand, all threads (master and workers) now use the same slot type, that's why `worker_rootS` was increased in size from `WARPSIZE-1` to `WARPSIZE`.
It is for the ibm-devel data sharing. We can take this out once we deprecate/remove the "old" data sharing scheme.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D49204