[Openmp-commits] [PATCH] D46842: [OpenMP][libomptarget] Make bitcode library building depend on clang and llvm-linker being available

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Jul 12 07:41:38 PDT 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D46842#1160050, @hfinkel wrote:

> In https://reviews.llvm.org/D46842#1159619, @Hahnfeld wrote:
>
> > I'm still opposed to this, as stated in my many comments. If at all, you need to make sure that this library doesn't rebuild whenever you do an unrelated change to Clang.
>
>
> I think that we should do the same thing here as we do with other things that are built with the just-built Clang (to be consistent with everything). By this metric, how does this compare?


I totally agree, but AFAIK nothing else depends on the just-built Clang except `runtimes/` and some `libc++` variants for testing.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D46842





More information about the Openmp-commits mailing list