[Openmp-commits] [PATCH] D49181: [OMPT] Adapt OMPT callback structure for tasks to handle untied tasks correctly (+ adapt testcase)

Simon Convent via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Jul 11 06:22:56 PDT 2018


sconvent created this revision.
sconvent added reviewers: protze.joachim, Hahnfeld, jlpeyton, hbae.

The ompt/tasks/task_types.c testcase did not test untied tasks properly. Now, frame addresses are tested and two scheduling points are added at which the task can switch to another thread. Due to scheduling effects, the frame address could be NULL.

This needed a restructure of the  way OMPT callbacks are called. `__ompt_task_finish()` now as an extra parameter, whether a task is completed. Its invocation has been moved into `__kmp_task_finish()`. Thus, the order of the writes to the frame addresses is not subject to scheduling effects anymore.


https://reviews.llvm.org/D49181

Files:
  runtime/src/kmp_tasking.cpp
  runtime/test/ompt/tasks/task_types.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49181.154972.patch
Type: text/x-patch
Size: 10326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180711/f09b0017/attachment.bin>


More information about the Openmp-commits mailing list