[Openmp-commits] [PATCH] D49105: [OpenMP] Cleanup code

[Jonathan Peyton via Phabricator via Openmp-commits]

jlpeyton created this revision.
jlpeyton added reviewers: tlwilmar, AndreyChurbanov.
jlpeyton added a project: OpenMP.
Herald added subscribers: guansong, mgorny.

This patch cleans up unused functions, variables, sign compare issues, and addresses some -Warning flags which are now enabled including `-Wcast-qual`.  Not all the warning flags in `LibompHandleFlags.cmake` are enabled, but some are with this patch.

Some `__kmp_gtid_from_*` macros in `kmp.h` are switched to static inline functions which allows us to remove the awkward definition of `KMP_DEBUG_ASSERT()` and `KMP_ASSERT()` macros which used the comma operator.  This had to be done for the innumerable `-Wunused-value` warnings related to `KMP_DEBUG_ASSERT()` (at least for gcc)


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D49105

Files:
  runtime/cmake/LibompHandleFlags.cmake
  runtime/cmake/config-ix.cmake
  runtime/src/kmp.h
  runtime/src/kmp_affinity.cpp
  runtime/src/kmp_affinity.h
  runtime/src/kmp_alloc.cpp
  runtime/src/kmp_atomic.cpp
  runtime/src/kmp_barrier.cpp
  runtime/src/kmp_csupport.cpp
  runtime/src/kmp_debug.h
  runtime/src/kmp_dispatch.cpp
  runtime/src/kmp_dispatch.h
  runtime/src/kmp_gsupport.cpp
  runtime/src/kmp_i18n.cpp
  runtime/src/kmp_lock.cpp
  runtime/src/kmp_lock.h
  runtime/src/kmp_runtime.cpp
  runtime/src/kmp_sched.cpp
  runtime/src/kmp_settings.cpp
  runtime/src/kmp_stats.cpp
  runtime/src/kmp_stats.h
  runtime/src/kmp_stub.cpp
  runtime/src/kmp_tasking.cpp
  runtime/src/kmp_wait_release.h
  runtime/src/ompt-general.cpp
  runtime/src/ompt-specific.h
  runtime/src/thirdparty/ittnotify/ittnotify_static.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49105.154721.patch
Type: text/x-patch
Size: 58750 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180709/10de8444/attachment-0001.bin>