[Openmp-commits] [PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:35
 extern __device__ __shared__ uint32_t execution_param;
+__device__ __shared__ omptarget_nvptx_SharedArgs omptarget_nvptx_sharedArgs;
 
----------------
Hahnfeld wrote:
> I'm not sure if this needs to be //defined// here... Hopefully this lightens up after rebasing ;-)
Yeah, I think this needs be be declared `extern` here and defined in `omp_data.cu`.


Repository:
  rL LLVM

https://reviews.llvm.org/D41485