[Openmp-commits] [PATCH] D42427: Fix broken OpenMP runtime test cases for Windows

[Joachim Protze via Phabricator via Openmp-commits]

protze.joachim added a comment.

In https://reviews.llvm.org/D42427#987710, @omalyshe wrote:

> In https://reviews.llvm.org/D42427#987692, @protze.joachim wrote:
>
> > @omalyshe do you have any advice, what is needed to make the `omp_control_tool` symbol available on Windows?
> >
> > My naive approach was to follow the things done for `omp_get_thread_num`.
>
>
> Adding omp_control_tool to dllexports is a right way.
>
> LGTM.


The problem is, that according to Hans' tests, the symbol is still not available in the runtime. The test (https://github.com/llvm-mirror/openmp/blob/master/runtime/test/ompt/misc/control_tool_no_ompt_support.c) litterally only calls this single function. But the linker complains about the missing symbol.


https://reviews.llvm.org/D42427