[Openmp-commits] [PATCH] D14254: [OpenMP] Initial implementation of OpenMP offloading library - libomptarget device RTLs.

[Gheorghe-Teodor Bercea via Phabricator via Openmp-commits]

gtbercea added a comment.
Herald added a subscriber: llvm-commits.

In https://reviews.llvm.org/D14254#969452, @Hahnfeld wrote:

> Two global remarks:
>
> 1. I think we agreed on having `<thread id> % <warp size>` instead of bit operations.


What's wrong with bit-wise operations as long as they are documented? I think we should keep them and then comment what it is that they do.

> 2. Somewhat related, there are currently at least four different "symbols" for the warp size: `warpSize`, `WARPSIZE`, `DS_Max_Worker_Warp_Size`, and `DS_Max_Warp_Number`. This needs to be exactly //one// that is used throughout the runtime.

I agree about the collapsing of the first two, maybe the 3rd. The 4th is the maximum number of warps per team AFAICT not the warp size (sure, it happens to be 32).


Repository:
  rL LLVM

https://reviews.llvm.org/D14254