[Openmp-commits] [PATCH] D38185: Implementation of OMPT as specified in OpenMP 5.0 Preview 1

Hans Wennborg via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 23 09:03:04 PST 2018


hans added a comment.

In https://reviews.llvm.org/D38185#985231, @protze.joachim wrote:

> In https://reviews.llvm.org/D38185#985047, @hans wrote:
>
> > Also, r317085 doesn't seem to have gone to any mailing list, which is unfortunate. Maybe because the committer was not subscribed and it got stuck in moderation.
>
>
> I think at the time of the commit, I was not subscribed with the matching mail address :( And I guess the size of the diff might also be a reason for the mailing list to put the mail on wait.
>
> Of the failing tests, we only added one with the OMPT commit:
>
> >   libomp :: misc_bugs/omp_foreign_thread_team_reuse.c
>
> https://reviews.llvm.org/D23084
>
> >   libomp :: ompt/misc/control_tool_no_ompt_support.c
>
> by this commit.
>
> >   libomp :: tasking/bug_nested_proxy_task.c
>
> https://reviews.llvm.org/D23115
>
> >   libomp :: tasking/bug_proxy_task_dep_waiting.c
>
> https://reviews.llvm.org/D23116
>
> I uploaded a diff, that should address all the broken test cases:
>  https://reviews.llvm.org/D42427


Thanks!



================
Comment at: openmp/trunk/runtime/src/ompt-general.cpp:118
+  ompt_start_tool_t next_tool = NULL;
+  next_tool = (ompt_start_tool_t)dlsym(RTLD_NEXT, "ompt_start_tool");
+  if (next_tool)
----------------
This fails on Windows obviously. When building with clang it looks like this:


```
[903/3933] Building CXX object projects\openmp\runtime\src\CMakeFiles\omp.dir\ompt-general.cpp.obj
FAILED: projects/openmp/runtime/src/CMakeFiles/omp.dir/ompt-general.cpp.obj
\src\llvm\build.release\bin\clang-cl.exe  /nologo -TP -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_DEBUG_POINTER_IMPL="" -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Domp_EXPORTS -Iprojects\openmp\runtime\src -I..\projects\openmp\runtime\src -Iinclude -I..\include -I..\projects\openmp\runtime\src\i18n -I..\projects\openmp\runtime\src\include\50 -I..\projects\openmp\runtime\src\thirdparty\ittnotify /DWIN32 /D_WINDOWS   /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wcovered-switch-default -Wdelete-non-virtual-dtor -Wstring-conversion /MT /O2 /Ob2   -UNDEBUG -D _CRT_SECURE_NO_WARNINGS -D _CRT_SECURE_NO_DEPRECATE -D _WINDOWS -D _WINNT -D _WIN32_WINNT=0x0501 -D _USRDLL -Wno-sign-compare -Wno-unused-function -Wno-unused-local-typedef -Wno-unused-value -Wno-unused-variable -Wno-switch -Wno-covered-switch-default -Wno-deprecated-register -Wno-gnu-anonymous-struct -Wno-unknown-pragmas -Wno-missing-field-initializers -Wno-missing-braces -Wno-comment -Wno-self-assign -Wno-vla-extension -Wno-format-pedantic /GS /EHsc /showIncludes /Foprojects\openmp\runtime\src\CMakeFiles\omp.dir\ompt-general.cpp.obj /Fdprojects\openmp\runtime\src\CMakeFiles\omp.dir\ -c ..\projects\openmp\runtime\src\ompt-general.cpp
..\projects\openmp\runtime\src\ompt-general.cpp(131,32):  error: use of undeclared identifier 'RTLD_NEXT'
      (ompt_start_tool_t)dlsym(RTLD_NEXT, "ompt_start_tool");
                               ^
```

But for some reason I don't see that when building with MSVC.


Repository:
  rL LLVM

https://reviews.llvm.org/D38185





More information about the Openmp-commits mailing list