[Openmp-commits] [PATCH] D41817: [OMPT] Enable OMPT on 32-bit ARM machines

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D41817#973066, @pawosm01 wrote:

> Ahh, I didn't say it isn't working, but I also didn't explicitly said that: when libomp+OMPT is built with clang on 32-bit ARM, all of OMPT test cases pass iff they are compiled with clang.
>  The problem is on 32-bit ARM and GCC.
>
>   Library built with: Clang  | GCC
>   Testing with:              |
>   Clang               works  | fails
>   GCC                 fails  | fails
>  
>


I didn't get that the Clang interface doesn't work if compiled with GCC :-(

In https://reviews.llvm.org/D41817#973080, @protze.joachim wrote:

> - Generally return NULL on arm32, if level>0: `#define OMPT_GET_FRAME_ADDRESS(level) ((level==0)?__builtin_frame_address(level):NULL)`


Why do these cases still exist, I though calling `__builtin_frame_address` with a level greater than 0 is undefined?

> The tricky part for testing any of these changes is how NULL is printed :(
>  I would feel better if we could provide something like (~(0L)) for the case where the frame address cannot be determined.

The spec says the runtime should return `NULL` in that case, there isn't much we can about that (except changing the spec).


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41817