[Openmp-commits] [PATCH] D41166: [OMPT] Rename ompt_mutex_impl_t to kmp_mutex_impl

[Simon Convent via Phabricator via Openmp-commits]

sconvent added inline comments.


================
Comment at: runtime/src/include/50/ompt.h.var:87
-#define FOREACH_OMPT_MUTEX_IMPL(macro)                                                \
-    macro (ompt_mutex_impl_unknown, 0)      /* unknown implementatin */               \
-    macro (ompt_mutex_impl_spin, 1)         /* based on spin */                       \
----------------
Hahnfeld wrote:
> This is actually defined in the spec, so we need to keep it prefixed with `ompt`
You're right. The spec specifies this value as a macro however (not an enum). I think we should wait for feedback on [[ https://github.com/OpenMPToolsInterface/OpenMP-4.5-spec/issues/112 | Github Issue 112]]


https://reviews.llvm.org/D41166