[Openmp-commits] [PATCH] D41817: [OMPT] Enable OMPT on 32-bit ARM machines

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D41817#971310, @pawosm01 wrote:

> Nah, doing architecture && compiler doesn't seem to work. I've got some better idea.


You'd have to add the architecture as a feature in the lit configuration script.

In https://reviews.llvm.org/D41817#971586, @pawosm01 wrote:

> I really like this message that proposed patch causes on ARM + gcc when someone's trying to set -DLIBOMP_OMPT_SUPPORT=ON:
>
>   CMake Error at runtime/cmake/LibompUtils.cmake:27 (message):
>     LIBOMP: OpenMP Tools Interface requested but not available in this
>     implementation
>   Call Stack (most recent call first):
>     runtime/CMakeLists.txt:316 (libomp_error_say)
>
>
> This is more clean solution than passing NULL which effects in less pleasant failures.


Does a Clang built runtime work for GCC? In particular, do all tests pass when building with Clang but adding `-DOPENMP_TEST_C_COMPILER=gcc -DOPENMP_TEST_CXX_COMPILER=g++`? If not, we should definitely think about returning `NULL` and what the spec says about this case.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41817