[Openmp-commits] [PATCH] D41817: [OMPT] Enable OMPT on 32-bit ARM machines and fix type mismatch in omp_control_tool implementation that makes it run incorrectly on 32-bit machines

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Jan 9 01:57:51 PST 2018


Hahnfeld added a comment.

In https://reviews.llvm.org/D41817#970687, @Hahnfeld wrote:

> In https://reviews.llvm.org/D41817#970686, @pawosm01 wrote:
>
> > It's kmp_gsupport.cpp issue I presume, was it ever tested on any 32-bit platform? I'll try to look at it through the day.
>
>
> Yes, all tests pass on i386 AFAICS


Nah, looks like I didn't recreate the build directories and OMPT was still disabled. With OMPT enabled, I need to fix `ompt_control` (can you please submit the change separately so that we can backport the fix to `release_60`?) and a wrong cast in `synchronization/lock.c` (working on a fix) - all other tests are green with latest Clang and GCC with `-m32` from x86_64.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41817





More information about the Openmp-commits mailing list