[Openmp-commits] [PATCH] D42523: [OMPT] Add api_calls_misc.c testcase and rename api_calls.c testcase

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Wed Feb 28 09:35:27 PST 2018


Hahnfeld added inline comments.


================
Comment at: runtime/test/ompt/misc/api_calls_places.c:65
 
-  // CHECK: {{^}}[[MASTER_ID:[0-9]+]]: omp_get_num_places()=[[NUM_PLACES:[0-9]+]]
+  // CHECK: {{^}}[[MASTER_ID:[0-9]+]]: omp_get_num_places()=
+  // CHECK-SAME:[[NUM_PLACES:[0-9]+]]
----------------
protze.joachim wrote:
> I suggest to move "=" to the next line to ensure that NUM_PLACES matches the right number?
(and I think you can readd a space between `CHECK-SAME:` and the rest, `FileCheck` //should// strip the whitespace from begin and end)


https://reviews.llvm.org/D42523





More information about the Openmp-commits mailing list