[Openmp-commits] [PATCH] D42472: [OMPT] Fix ompt_get_task_info() and add tests for it

Jonas Hahnfeld via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Sat Feb 24 00:25:17 PST 2018


Hahnfeld added a comment.

You should probably explain why each task is in its own `single` region and why that works as discussed internally.



================
Comment at: runtime/test/ompt/callback.h:36
 
+static void format_task_type(int type, char* buffer)
+{
----------------
This function is not formatted.


================
Comment at: runtime/test/ompt/callback.h:73-75
 static void print_ids(int level)
 {
+  int task_type, thread_num;
----------------
Same


https://reviews.llvm.org/D42472





More information about the Openmp-commits mailing list