[Openmp-commits] [PATCH] D43568: [OMPT] Rename ompt_frame_t to omp_frame_t

[Olga Malysheva via Phabricator via Openmp-commits]

omalyshe added a comment.

Do we really need this change? 
I found a comment from John M-C at https://github.com/OpenMPToolsInterface/OpenMP-4.5-spec/commit/7bed0e0e6b96e0cfa6d964de2101c2172a0a47e7#commitcomment-24561958 (that commit replaced ompt_frame_t to omp_frame_t in the Spec):

> This change needs to be reverted. We had originally planned to use omp_frame_t, but now are using ompt_frame_t because it turns out that we can't share the type: OMPD needs ompd_address_t instead of void * for the addresses.





================
Comment at: runtime/src/include/50/ompt.h.var:302
     ompt_data_t *encountering_task_data,         /* data of encountering task           */
-    const ompt_frame_t *encountering_task_frame, /* frame data of encountering task     */
+    const omp_frame_t *encountering_task_frame, /* frame data of encountering task     */
     ompt_data_t *parallel_data,                  /* data of parallel region             */
----------------
Add space before /*


================
Comment at: runtime/src/include/50/ompt.h.var:344
     ompt_data_t *encountering_task_data,         /* data of parent task                 */
-    const ompt_frame_t *encountering_task_frame, /* frame data for parent task          */
+    const omp_frame_t *encountering_task_frame, /* frame data for parent task          */
     ompt_data_t *new_task_data,                  /* data of created task                */
----------------
Add space before /*



https://reviews.llvm.org/D43568