[Openmp-commits] [PATCH] D43191: [OMPT] Fix test tasks/serialized.c with optimization

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: runtime/test/ompt/tasks/serialized.c:146
+  // CHECK: {{^}}[[THREAD_ID]]: ompt_event_barrier_end
+  // CHECK-SAME: parallel_id={{[0-9]+}}, task_id=[[IMPLICIT_TASK_ID]]
 
----------------
protze.joachim wrote:
> protze.joachim wrote:
> > Hahnfeld wrote:
> > > omalyshe wrote:
> > > > Looks like parallel_id should be checked for PARALLEL_ID here. 
> > > > Same on line 149.
> > > This doesn't work, `parallel_id=0` for these two events. I'd guess that's because the parallel region ended in the barrier, @protze.joachim?
> > Yes, parallel_id=0 would be the right check for all worker threads.
> Sorry, for all threads.
Ok, that turns out to be a bug for master threads. I've posted a fix in D43308.


https://reviews.llvm.org/D43191