[Openmp-commits] [PATCH] D43308: [OMPT] Fix parallel_data in implicit barrier-end

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a subscriber: sconvent.
Hahnfeld added inline comments.


================
Comment at: runtime/test/ompt/parallel/normal.c:33-35
+  // Note that we don't check the arguments of the calllbacks because FileCheck
+  // doesn't support CHECK-DAG-SAME (these lines are silently ignored).
+  // Instead this is done with the THREADS prefix.
----------------
Another option would be to only use `CHECK-DAG` but this doesn't enforce the requirement that the arguments are on the same line. IMO we don't lose any coverage because the same information is checked in `THREADS`.

To be honest, I even think we could drop the previous `CHECK-SAME` lines and only check that we get the right callbacks before `parallel_end`...


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D43308