[Openmp-commits] [PATCH] D41942: [OMPT] Add interoperability testcase

[Olga Malysheva via Phabricator via Openmp-commits]

omalyshe requested changes to this revision.
omalyshe added inline comments.
This revision now requires changes to proceed.


================
Comment at: runtime/test/ompt/misc/interoperability.cpp:39
+
+  // CHECK: {{^}}[[THREAD_ID:[0-9]+]]: ompt_event_thread_begin: thread_type=ompt_thread_initial=1, thread_id=[[THREAD_ID]]
+  // CHECK: {{^}}[[THREAD_ID]]: ompt_event_task_create: parent_task_id=0, parent_task_frame.exit=[[NULL]], parent_task_frame.reenter=[[NULL]], new_task_id=[[OTHER_PARENT_TASK_ID:[0-9]+]], codeptr_ra=[[NULL]], task_type=ompt_task_initial=1, has_dependences=no
----------------
These three checks relates to the second master thread, so  to make it clear I'd suggest naming it MASTER_ID_2. 


================
Comment at: runtime/test/ompt/misc/interoperability.cpp:46
+  // CHECK: {{^}}[[THREAD_ID:[0-9]+]]: ompt_event_thread_begin: thread_type=ompt_thread_worker=2, thread_id=[[THREAD_ID]]
+
----------------
Two checks above should has different thread ids, that is THREAD_ID_1, THREAD_ID_2 (something like that). 

I also suggest adding CHECK for *_end events for all *_begin events above.


https://reviews.llvm.org/D41942