[Openmp-commits] [PATCH] D41485: [OpenMP][libomptarget] Add data sharing support in libomptarget

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.cu:35
 extern __device__ __shared__ uint32_t execution_param;
+__device__ __shared__ omptarget_nvptx_SharedArgs omptarget_nvptx_sharedArgs;
 
----------------
Hahnfeld wrote:
> Hahnfeld wrote:
> > Hahnfeld wrote:
> > > I'm not sure if this needs to be //defined// here... Hopefully this lightens up after rebasing ;-)
> > Yeah, I think this needs be be declared `extern` here and defined in `omp_data.cu`.
> Actually, all of these `extern` declarations should go away because they already exist in `omptarget-nvptx.h`! We don't need to reiterate them here...
I still think this won't work: If there are multiple translation units with `target` regions, the linker should complain about duplicate symbol definitions... I think that's why there is a separate file `omp_data.cu`.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D41485