[Openmp-commits] [PATCH] D55479: [openmp] [runtime] [test] Use more portable short options to sort(1)

[Michał Górny via Phabricator via Openmp-commits]

mgorny created this revision.
mgorny added reviewers: krytarowski, Hahnfeld, jlpeyton.
Herald added subscribers: guansong, emaste.

Pass `-n -s` instead of `--numeric --stable` to sort(1), as long options
are not supported by NetBSD sort implementation.  `-n` is defined
by POSIX, so it should be fully portable.  `-s` is used consistently
at least in GNU sort and FreeBSD sort, and I honestly doubt it would
cause issues with any other implementation supporting `--stable`.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D55479

Files:
  runtime/test/lit.cfg


Index: runtime/test/lit.cfg
===================================================================
--- runtime/test/lit.cfg
+++ runtime/test/lit.cfg
@@ -116,7 +116,7 @@
 
 if config.has_ompt:
     config.substitutions.append(("FileCheck", config.test_filecheck))
-    config.substitutions.append(("%sort-threads", "sort --numeric-sort --stable"))
+    config.substitutions.append(("%sort-threads", "sort -n -s"))
     if config.operating_system == 'Windows':
         # No such environment variable on Windows.
         config.substitutions.append(("%preload-tool", "true ||"))


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55479.177398.patch
Type: text/x-patch
Size: 575 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20181208/091b68b1/attachment.bin>