[Openmp-commits] [PATCH] D51226: [OpenMP][libomptarget] rework of fatal error reporting

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld accepted this revision.
Hahnfeld added a comment.

As long as we don't need to change back to the current way of doing things next week, I think I'm also fine with the macro if you think it's better. Please address the inline comment about `do { ... } while (0)` before committing.



================
Comment at: libomptarget/src/private.h:53
+    exit(1);                                                          \
+  }
+
----------------
Hahnfeld wrote:
> If anything please use the `do { ... } while (0)` logic, that's actually a good thing for macros: https://stackoverflow.com/a/1067238
Ping!


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51226