[Openmp-commits] [PATCH] D51226: [OpenMP][libomptarget] rework of fatal error reporting

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a subscriber: ABataev.
Hahnfeld added a comment.

@ABataev what's wrong with `cstdarg`?

In the end I don't have a strong opinion here (just a general dislike of too many nasty macros), but in the end it's hard to review a change without any justifaction.



================
Comment at: libomptarget/src/private.h:53
+    exit(1);                                                          \
+  }
+
----------------
If anything please use the `do { ... } while (0)` logic, that's actually a good thing for macros: https://stackoverflow.com/a/1067238


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51226