[Openmp-commits] [PATCH] D51226: [OpenMP][libomptarget] rework of fatal error reporting

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D51226#1212699, @AlexEichenberger wrote:

> In https://reviews.llvm.org/D51226#1212685, @Hahnfeld wrote:
>
> > I don't understand this: In the last review you said that we need the complicated `FatalMessage` and now you are reverting that?!?
>
>
> I am reimplementing this because it needs an include that may be fragile on some platforms (https://reviews.llvm.org/D51219)


Can you please elaborate on "fragile"? It's in the standard, we can just use that include!

> using the #def, I can avoid getting a lock as the whole printing is done in one fprintf

(I suggested this back in https://reviews.llvm.org/D50522#1199469)


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51226