[Openmp-commits] [PATCH] D51107: [LIBOMPTARGET] Add support for mapping of lambda captures.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/src/omptarget.cpp:623
+        uint64_t Delta = (uint64_t)HstPtrBegin - (uint64_t)HstPtrBase;
+        void *TgtPtrBegin = (void *)((uintptr_t)TgtPtrBase + Delta);
+        void *Pointer_TgtPtrBegin = Device.getTgtPtrBegin(
----------------
RaviNarayanaswamy wrote:
> We should not be doing target arithmetic in omptarget.cpp.  The target pointer can be an opaque object for some implementation. 
> Yes we should clean up code in other places which do this.
How should we handle elements that are part of structures?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51107