[Openmp-commits] [PATCH] D50774: [OMPT] Update types according to TR7

Hansang Bae via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 23 10:03:57 PDT 2018


hbae added inline comments.


================
Comment at: runtime/src/kmp_csupport.cpp:2571
   int acquire_status =
       KMP_D_LOCK_FUNC(user_lock, set)((kmp_dyna_lock_t *)user_lock, gtid);
+#endif
----------------
Invocation of the lock function should be outside of the OMPT code.


================
Comment at: runtime/src/kmp_csupport.cpp:2764
+  int release_status =
+      KMP_D_LOCK_FUNC(user_lock, unset)((kmp_dyna_lock_t *)user_lock, gtid);
   // This is the case, if called from omp_init_lock_with_hint:
----------------
Same here.


https://reviews.llvm.org/D50774





More information about the Openmp-commits mailing list