[Openmp-commits] [PATCH] D51107: [LIBOMPTARGET] Add support for mapping of lambda captures.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added inline comments.


================
Comment at: libomptarget/src/omptarget.cpp:637-638
+          DP("Copying data to device failed.\n");
+          rc = OFFLOAD_FAIL;
+          break;
+        }
----------------
Hahnfeld wrote:
> ABataev wrote:
> > Hahnfeld wrote:
> > > After D50522 this should probably be `return OFFLOAD_FAIL`
> > I think this code is ok. It exits from the main loop and then returns `rc` as a result. 
> Yep, and D50522 changes the existing code to `return OFFLOAD_FAIL` so this patch should do the same.
Ahh, now I see. Do you want me to make it return `OFFLOAD_FAIL` right now or after D50522 is landed?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D51107