[Openmp-commits] [PATCH] D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var

Alexandre Eichenberger via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Aug 16 06:26:30 PDT 2018


AlexEichenberger updated this revision to Diff 161016.
AlexEichenberger added a comment.

Thanks to all for your valuable comments, much appreciated, really contributed to the quality of the patch

Looking thourhg the code one more time, I realized that there was no default init for this key variable

kmp_target_offload_kind_t TargetOffloadPolicy = tgt_default;

It's better for it to be init to zero value, to be absolutely safe.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D50522

Files:
  libomptarget/src/interface.cpp
  libomptarget/src/omptarget.cpp
  libomptarget/src/private.h
  libomptarget/src/rtl.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50522.161016.patch
Type: text/x-patch
Size: 19717 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/openmp-commits/attachments/20180816/bcf4bc3b/attachment-0001.bin>


More information about the Openmp-commits mailing list