[Openmp-commits] [PATCH] D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var

[Alexandre Eichenberger via Phabricator via Openmp-commits]

AlexEichenberger marked an inline comment as done.
AlexEichenberger added inline comments.


================
Comment at: libomptarget/src/interface.cpp:52
     DP("Failed to get device %" PRId64 " ready\n", device_id);
+    handle_target_outcome(false);
     return;
----------------
RaviNarayanaswamy wrote:
> Why not move the check of handle_target_outcome into CheckDeviceAndCtors  so you dont have to do every time you invoke this function.
Ravi, I did your change but reverted it for the following reason. I liked to have all of the handling of target_offload variable in the same file (interface.cpp). When I moved in into the CheckDeviceAndCtors, I needed to insert it in 2 places within the function, and handle_target_outcome was now in two different files.

If you feel strongly about your request, I will be happy to move the code into CheckDeviceAndCtors.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D50522