[Openmp-commits] [PATCH] D50158: [OpenMP] Add placeholder functions for the depend and nowait depend clauses for target data directives.

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D50158#1185974, @gtbercea wrote:

> These calls are here because they require the interface of libomp library include these functions. A patch for Clang is in the works which calls these functions so they need to have some basic, correct implementation that works when used with libomp.
>  The implementation can/should be improved in the future. In our proprietary OpenMP library implementation we already do something more elaborate which is why we need the placeholders here.


Can you at least partly explain why the compiler generated code cannot call `__kmpc_omp_taskwait` for directives that have no `nowait` clause? Including a change because "we need it for our proprietary implementation" is a weak argument IMO...


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D50158