[Openmp-commits] [PATCH] D50158: [OpenMP] Add placeholder functions for the depend and nowait depend clauses for target data directives.

[Alexey Bataev via Phabricator via Openmp-commits]

ABataev added a comment.

In https://reviews.llvm.org/D50158#1185919, @Hahnfeld wrote:

> In https://reviews.llvm.org/D50158#1185906, @RaviNarayanaswamy wrote:
>
> > We should not be having calls to _-kmpc_omp_taskwait in libomptarget.
> >  The wait should be done in the user code and then libomptarget routine should be called.
>
>
> There is no way to implement asynchronous offloading without having knowledge of the dependencies. Intel failed to keep the separation strict for liboffload, so I don't think it helps to complain about the situation.


Instead, we may pass the pointer to the synchronization function and call it. The compiler may provide the pointer to this sync function. The expected function may be simple (like void sync()), the compiler may generate the required wrapper function around `__kmpc_omp_taskwait`


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D50158