[Openmp-commits] [openmp] r338720 - [tests] Add annotations for taskloop features

[Jonas Hahnfeld via Openmp-commits]

Hi Hans,

can we also backport this commit? It prevents these tests from running 
with compilers that didn't support this feature of OpenMP...

Thanks,
Jonas

On 2018-08-02 16:34, Jonas Hahnfeld via Openmp-commits wrote:
> Author: hahnfeld
> Date: Thu Aug  2 07:34:03 2018
> New Revision: 338720
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=338720&view=rev
> Log:
> [tests] Add annotations for taskloop features
> 
> Only supported since GCC 6 and Intel 17.0. However GCC 6.3.0 is
> crashing on two of the tests, so disable them as well...
> 
> Differential Revision: https://reviews.llvm.org/D50085
> 
> Modified:
>     openmp/trunk/runtime/test/ompt/tasks/taskloop.c
>     openmp/trunk/runtime/test/tasking/omp_taskloop_grainsize.c
>     openmp/trunk/runtime/test/tasking/omp_taskloop_num_tasks.c
> 
> Modified: openmp/trunk/runtime/test/ompt/tasks/taskloop.c
> URL:
> http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/test/ompt/tasks/taskloop.c?rev=338720&r1=338719&r2=338720&view=diff
> ==============================================================================
> --- openmp/trunk/runtime/test/ompt/tasks/taskloop.c (original)
> +++ openmp/trunk/runtime/test/ompt/tasks/taskloop.c Thu Aug  2 07:34:03 
> 2018
> @@ -1,6 +1,12 @@
>  // RUN: %libomp-compile-and-run | FileCheck %s
>  // RUN: %libomp-compile-and-run | FileCheck --check-prefix=TASKS %s
>  // REQUIRES: ompt
> +
> +// These compilers don't support the taskloop construct
> +// UNSUPPORTED: gcc-4, gcc-5, icc-16
> +// GCC 6 has support for taskloops, but at least 6.3.0 is crashing on 
> this test
> +// UNSUPPORTED: gcc-6
> +
>  #include "callback.h"
>  #include <omp.h>
> 
> 
> Modified: openmp/trunk/runtime/test/tasking/omp_taskloop_grainsize.c
> URL:
> http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/test/tasking/omp_taskloop_grainsize.c?rev=338720&r1=338719&r2=338720&view=diff
> ==============================================================================
> --- openmp/trunk/runtime/test/tasking/omp_taskloop_grainsize.c 
> (original)
> +++ openmp/trunk/runtime/test/tasking/omp_taskloop_grainsize.c Thu Aug
>  2 07:34:03 2018
> @@ -1,5 +1,11 @@
>  // RUN: %libomp-compile-and-run
>  // RUN: %libomp-compile && env KMP_TASKLOOP_MIN_TASKS=1 %libomp-run
> +
> +// These compilers don't support the taskloop construct
> +// UNSUPPORTED: gcc-4, gcc-5, icc-16
> +// GCC 6 has support for taskloops, but at least 6.3.0 is crashing on 
> this test
> +// UNSUPPORTED: gcc-6
> +
>  /*
>   * Test for taskloop
>   * Method: caculate how many times the iteration space is dispatched
> 
> Modified: openmp/trunk/runtime/test/tasking/omp_taskloop_num_tasks.c
> URL:
> http://llvm.org/viewvc/llvm-project/openmp/trunk/runtime/test/tasking/omp_taskloop_num_tasks.c?rev=338720&r1=338719&r2=338720&view=diff
> ==============================================================================
> --- openmp/trunk/runtime/test/tasking/omp_taskloop_num_tasks.c 
> (original)
> +++ openmp/trunk/runtime/test/tasking/omp_taskloop_num_tasks.c Thu Aug
>  2 07:34:03 2018
> @@ -1,5 +1,9 @@
>  // RUN: %libomp-compile-and-run
>  // RUN: %libomp-compile && env KMP_TASKLOOP_MIN_TASKS=1 %libomp-run
> +
> +// These compilers don't support the taskloop construct
> +// UNSUPPORTED: gcc-4, gcc-5, icc-16
> +
>  /*
>   * Test for taskloop
>   * Method: caculate how many times the iteration space is dispatched
> 
> 
> _______________________________________________
> Openmp-commits mailing list
> Openmp-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/openmp-commits