[Openmp-commits] [PATCH] D46185: [OpenMP] Allow nvptx sm_30 to be used as an offloading device

[Guansong Zhang via Phabricator via Openmp-commits]

guansong added a comment.

In https://reviews.llvm.org/D46185#1081368, @Hahnfeld wrote:

> In https://reviews.llvm.org/D46185#1081362, @guansong wrote:
>
> > In https://reviews.llvm.org/D46185#1081124, @Hahnfeld wrote:
> >
> > > Anyway, why do you want to support `sm_30`? Is there a particular hardware that you want to support? Why does AMD care?!?
> >
> >
> > I will double check with Greg on the way atomicCAS used in the code. For the last question here. We have sm_30 machine for testing. Besides, from my perspective, I care the overall implementation of openmp, particularly the offloading part, not necessarily amdgcn code only :)
>
>
> Okay, then the question is: Will the implementation get better if it supports 6 years old hardware with yet another code path that only few people care about and that will get less testing? From intuition I doubt that because extra code for old hardware won't get much support and attention by definition.


I see your point. It will always be the more people testing the better, especially for people playing with devices. For the moment, my feeling is that this is a small regression we should try to fix before we give up the device.


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D46185