[Openmp-commits] [PATCH] D45530: [OpenMP] Make bc file compilation sensitive to LIBOMPTARGET_NVPTX_DEBUG flag

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added inline comments.


================
Comment at: libomptarget/deviceRTLs/nvptx/CMakeLists.txt:146
+      # Activate RTL message dumps if requested by the user.
+      set(LIBOMPTARGET_BC_DEBUG FALSE CACHE BOOL
+        "Activate BC code device RTL debug messages.")
----------------
guansong wrote:
> guansong wrote:
> > Hahnfeld wrote:
> > > Hmm, why does `Sync` mean a new variable? If that's what you want, it should start with `LIBOMPTARGET_NVPTX` and be properly documented
> > Thanks. I put a typo there, it should be 
> > 
> > set(BC_DEBUG FALSE CACHE BOOL
> > 
> > As I used in the next few lines. BC_DEBUG is an internal var. The behavior to sync is the Cmake command line def LIBOMPTARGET_NVPTX_DEBUG
> Look at this again, I am thinking I don't need these few lines. The BC_DEBUG will be defined either way in the following if block.
In that case it must not be `CACHE`. You can define `BC_DEBUG` to `-DOMPTARGET_NVPTX_DEBUG=0` and overwrite it `if(${LIBOMPTARGET_NVPTX_DEBUG})`


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D45530