[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Mon Apr 9 09:20:01 PDT 2018
Hahnfeld added a comment.
> ! In https://reviews.llvm.org/D44992#1061781, @guansong wrote:
> I have revert the change, let's continue to discuss how to enable bc file path better.
You are still not subscribed to `openmp-commits`, so again no commit email! For reference, the commit is https://reviews.llvm.org/rL329576 (and you shouldn't quote git commit hashes, there is a script in LLVM to revert SVN changes from git-svn.)
In https://reviews.llvm.org/D44992#1061815, @guansong wrote:
> In https://reviews.llvm.org/D44992#1061781, @guansong wrote:
> > I can see the advantage of dynamic testing. But to test everything dynamically maybe tedious. For bc file handling, I consider this is more of a project need to embed LLVM itself, using find_package is more suitable. http://llvm.org/docs/CMake.html#embedding
> proper link: http://llvm.org/docs/CMake.html#embedding-llvm-in-your-project
We probably don't need to test all flags on their own, we could group the basic flags together. And I still don't get which variable you want to use from that CMake integration?
More information about the Openmp-commits