[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang

[Jonas Hahnfeld via Phabricator via Openmp-commits]

Hahnfeld added a comment.

In https://reviews.llvm.org/D44992#1060992, @guansong wrote:

> > We shouldn't hardcode the versions. I'd propose the following:
> > 
> > 1. Can `LIBOMPTARGET_NVPTX_SELECTED_CUDA_COMPILER` compile `extern __shared__` without additional flag? (pre Clang 4.0)
> > 2. If we add `-fcuda-rdc` will it work then? (Clang trunk and later on released version 7.0)
> > 
> >   In both cases, we should default `LIBOMPTARGET_NVPTX_ENABLE_BCLIB` to `On`. (All these checks should probably reside in some `config-ix.cmake`...)
>
> Checking that way is good, though personally I am in favor of using find llvm package to check LLVM version. Regardless I think we want the same thing here, i.e. to enable the bc lib path by default.


Again: I'm against any hardcoding of compiler versions, support for flags can be detected dynamically. As such I don't see the point of using `find_package`, can you give an example which information you'd like to use from there?


Repository:
  rOMP OpenMP

https://reviews.llvm.org/D44992