[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang

Guansong Zhang via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Thu Apr 5 07:35:06 PDT 2018

guansong added a comment.

In https://reviews.llvm.org/D44992#1057123, @Hahnfeld wrote:

> In https://reviews.llvm.org/D44992#1057094, @gregrodgers wrote:
> > So , will the deviceRTLs/nvptx change?   Instead of `extern __shared__`, what will it use for those data structures?
> I don't question the flag, as I said `libomptarget-nvptx` was the main reason to implement that functionality. What's bad about this is adding this flag unconditionally, the build system needs to properly detect if the compiler supports it.
> If you can't work on that right now, I hereby request this change to be reverted as it results in a build regression.

I see. I will take your advice to guard this flag with clang version, so we can have a way to test the bc file path with the latest clang (7.0). This is an important path for device which will take advantage of llvm linker/link time optimizer.

I don't think this is a regression through, as it is broken right now unless one uses an older (less 4.0) clang. Besides the bc file path is only enabled under -DLIBOMPTARGET_NVPTX_ENABLE_BCLIB=1.

  rOMP OpenMP


More information about the Openmp-commits mailing list