[Openmp-commits] [PATCH] D44992: [OpenMP] enable bc file compilation using the latest clang
Jonas Hahnfeld via Phabricator via Openmp-commits
openmp-commits at lists.llvm.org
Tue Apr 3 10:32:43 PDT 2018
Hahnfeld added a comment.
Post-commit because your commit didn't trigger an email (please subscribe to openmp-commits!).
IMO this is wrong and should be reverted. What should be done instead is detect whether the compiler supports that flag because it was only added recently. Older compilers (pre 4.0?) are able to build bclib without that flag. In both cases, the build system should enable the bclib by default because it's sensible to do.
Regarding performance: Relocatable code is possibly slower, but we only use that flag to produce bitcode which is inlined by the compiler. However, I'm still working on that feature (see https://reviews.llvm.org/D42922) and I can't say for sure that we won't end up emitting different IR once the support matures. So this definitely needs to be considered. That's also the reason why I didn't submit a patch yet.
More information about the Openmp-commits