[Openmp-commits] [PATCH] D39439: [OpenMP]Fix race condition in omp_init_lock

Andrey Churbanov via Phabricator via Openmp-commits openmp-commits at lists.llvm.org
Tue Oct 31 06:11:08 PDT 2017

AndreyChurbanov added a comment.

Failure to reproduce the bug does not mean there is no bug:).  The library code change looks good, but please fix the test.

Comment at: testsuite/omp_testsuite.h:49
 int crosstest_omp_lock(FILE * logfile);  /* Crosstest for omp_lock */
+int test_omp_init_lock(FILE * logfile);  /* Test for omp_init_lock */
+int crosstest_omp_init_lock(FILE * logfile);  /* Crosstest for omp_init_lock */
I am not an expert in testsuite test system, but I would guess that this change could break it.  Because you added test references without adding the test itself.

Couple more notes:
- this header file is auto generated, according to the comment at the beginning of the file;
- this folder looks outdated in general, as all new tests related activity and LIT testing happens in the runtime/test location, so I doubt you need to touch this file.


More information about the Openmp-commits mailing list